summaryrefslogtreecommitdiffstats
path: root/fs/nfsd
diff options
context:
space:
mode:
authorJ. Bruce Fields <bfields@redhat.com>2012-06-05 16:29:06 -0400
committerJ. Bruce Fields <bfields@redhat.com>2012-06-20 08:59:41 -0400
commit9068bed1a35da413df8751b8b1b845a04f62b9fd (patch)
treecc246fdcc0551b2adb5cd7687a739831887374e6 /fs/nfsd
parent7df302f75ee28a6a87436e93b625ef60d37d098e (diff)
downloadblackbird-op-linux-9068bed1a35da413df8751b8b1b845a04f62b9fd.tar.gz
blackbird-op-linux-9068bed1a35da413df8751b8b1b845a04f62b9fd.zip
nfsd4: remove unnecessary comment
For the most part readers of cl_cb_state only need a value that is "eventually" right. And the value is set only either 1) in response to some change of state, in which case it's set to UNKNOWN and then a callback rpc is sent to probe the real state, or b) in the handling of a response to such a callback. UNKNOWN is therefore always a "temporary" state, and for the other states we're happy to accept last writer wins. So I think we're OK here. Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/nfsd')
-rw-r--r--fs/nfsd/nfs4callback.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index a5fd6b982f27..cbaf4f8bb7b7 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -756,7 +756,6 @@ static void do_probe_callback(struct nfs4_client *clp)
*/
void nfsd4_probe_callback(struct nfs4_client *clp)
{
- /* XXX: atomicity? Also, should we be using cl_flags? */
clp->cl_cb_state = NFSD4_CB_UNKNOWN;
set_bit(NFSD4_CLIENT_CB_UPDATE, &clp->cl_flags);
do_probe_callback(clp);
OpenPOWER on IntegriCloud