diff options
| author | Jonathan Corbet <corbet@lwn.net> | 2009-02-06 15:25:24 -0700 |
|---|---|---|
| committer | Jonathan Corbet <corbet@lwn.net> | 2009-03-16 08:32:27 -0600 |
| commit | db1dd4d376134eba0e08af523b61cc566a4ea1cd (patch) | |
| tree | 8882c673abbaa5713511b7046493fa862b9140d1 /fs/fcntl.c | |
| parent | 684999149002dd046269666a390458e0acb38280 (diff) | |
| download | blackbird-op-linux-db1dd4d376134eba0e08af523b61cc566a4ea1cd.tar.gz blackbird-op-linux-db1dd4d376134eba0e08af523b61cc566a4ea1cd.zip | |
Use f_lock to protect f_flags
Traditionally, changes to struct file->f_flags have been done under BKL
protection, or with no protection at all. This patch causes all f_flags
changes after file open/creation time to be done under protection of
f_lock. This allows the removal of some BKL usage and fixes a number of
longstanding (if microscopic) races.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Diffstat (limited to 'fs/fcntl.c')
| -rw-r--r-- | fs/fcntl.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/fcntl.c b/fs/fcntl.c index bd215cc791da..04df8570a2d2 100644 --- a/fs/fcntl.c +++ b/fs/fcntl.c @@ -189,7 +189,9 @@ static int setfl(int fd, struct file * filp, unsigned long arg) } } + spin_lock(&filp->f_lock); filp->f_flags = (arg & SETFL_MASK) | (filp->f_flags & ~SETFL_MASK); + spin_unlock(&filp->f_lock); out: unlock_kernel(); return error; |
