diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-12-10 09:56:01 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-01-06 10:40:14 +0100 |
| commit | acf3efd6f0037582209cc589392a06ed26d9032b (patch) | |
| tree | 2ab75e7fbfe61746427c9516443e928a8f540a22 /fs/ext4 | |
| parent | 3e4f8da9d177b447fdd5e82c94f66bac38aa3045 (diff) | |
| download | blackbird-op-linux-acf3efd6f0037582209cc589392a06ed26d9032b.tar.gz blackbird-op-linux-acf3efd6f0037582209cc589392a06ed26d9032b.zip | |
ext4: return -ENOMEM instead of success
commit 578620f451f836389424833f1454eeeb2ffc9e9f upstream.
We should set the error code if kzalloc() fails.
Fixes: 67cf5b09a46f ("ext4: add the basic function for inline data support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/inline.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c index f74d5ee2cdec..d8ca4b9f9dd6 100644 --- a/fs/ext4/inline.c +++ b/fs/ext4/inline.c @@ -336,8 +336,10 @@ static int ext4_update_inline_data(handle_t *handle, struct inode *inode, len -= EXT4_MIN_INLINE_DATA_SIZE; value = kzalloc(len, GFP_NOFS); - if (!value) + if (!value) { + error = -ENOMEM; goto out; + } error = ext4_xattr_ibody_get(inode, i.name_index, i.name, value, len); |
