diff options
| author | Andi Kleen <andi@firstfloor.org> | 2008-10-06 21:37:44 -0400 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2008-10-06 21:37:44 -0400 |
| commit | 39d80c33a068d9fa63a36c3b2c0d718d38440dd1 (patch) | |
| tree | 6110ca4101f533ced0db2fe18a7834cd8304f0a3 /fs/ext4 | |
| parent | 08a225f143bf3415fef6f3360d922be35da40543 (diff) | |
| download | blackbird-op-linux-39d80c33a068d9fa63a36c3b2c0d718d38440dd1.tar.gz blackbird-op-linux-39d80c33a068d9fa63a36c3b2c0d718d38440dd1.zip | |
ext4: Avoid double dirtying of super block in ext4_put_super()
While reading code I noticed that ext4_put_super() dirties the
superblock bh twice. It is always done in ext4_commit_super()
too. Remove the redundant dirty operation.
Should be a nop semantically.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/super.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 9c0214689de0..7d865608e817 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -512,8 +512,6 @@ static void ext4_put_super(struct super_block *sb) if (!(sb->s_flags & MS_RDONLY)) { EXT4_CLEAR_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_RECOVER); es->s_state = cpu_to_le16(sbi->s_mount_state); - BUFFER_TRACE(sbi->s_sbh, "marking dirty"); - mark_buffer_dirty(sbi->s_sbh); ext4_commit_super(sb, es, 1); } if (sbi->s_proc) { |
