diff options
| author | David Teigland <teigland@redhat.com> | 2009-11-30 16:34:43 -0600 |
|---|---|---|
| committer | David Teigland <teigland@redhat.com> | 2009-11-30 16:34:43 -0600 |
| commit | 573c24c4af6664ffcd9aa7ba617a35fde2b95534 (patch) | |
| tree | 9222c0c8921fda5b842c2d1007d911d47bd4fe7c /fs/dlm/requestqueue.c | |
| parent | a8a8a669ea13d792296737505adc43ccacf3a648 (diff) | |
| download | blackbird-op-linux-573c24c4af6664ffcd9aa7ba617a35fde2b95534.tar.gz blackbird-op-linux-573c24c4af6664ffcd9aa7ba617a35fde2b95534.zip | |
dlm: always use GFP_NOFS
Replace all GFP_KERNEL and ls_allocation with GFP_NOFS.
ls_allocation would be GFP_KERNEL for userland lockspaces
and GFP_NOFS for file system lockspaces.
It was discovered that any lockspaces on the system can
affect all others by triggering memory reclaim in the
file system which could in turn call back into the dlm
to acquire locks, deadlocking dlm threads that were
shared by all lockspaces, like dlm_recv.
Signed-off-by: David Teigland <teigland@redhat.com>
Diffstat (limited to 'fs/dlm/requestqueue.c')
| -rw-r--r-- | fs/dlm/requestqueue.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/dlm/requestqueue.c b/fs/dlm/requestqueue.c index 7a2307c08911..a44fa22890e1 100644 --- a/fs/dlm/requestqueue.c +++ b/fs/dlm/requestqueue.c @@ -35,7 +35,7 @@ void dlm_add_requestqueue(struct dlm_ls *ls, int nodeid, struct dlm_message *ms) struct rq_entry *e; int length = ms->m_header.h_length - sizeof(struct dlm_message); - e = kmalloc(sizeof(struct rq_entry) + length, ls->ls_allocation); + e = kmalloc(sizeof(struct rq_entry) + length, GFP_NOFS); if (!e) { log_print("dlm_add_requestqueue: out of memory len %d", length); return; |
