diff options
author | Jeff Layton <jlayton@redhat.com> | 2010-10-11 15:07:18 -0400 |
---|---|---|
committer | Steve French <sfrench@us.ibm.com> | 2010-10-12 18:06:42 +0000 |
commit | a5e18bc36e9e05ce0338d370a2ce4290910e43ea (patch) | |
tree | 9d8b37c1dd20267c372ff8c98850eeb2f204449b /fs/cifs/file.c | |
parent | 1c456013e96f10915578dc61095d19b4906f64ac (diff) | |
download | blackbird-op-linux-a5e18bc36e9e05ce0338d370a2ce4290910e43ea.tar.gz blackbird-op-linux-a5e18bc36e9e05ce0338d370a2ce4290910e43ea.zip |
cifs: keep dentry reference in cifsFileInfo instead of inode reference
cifsFileInfo is a bit problematic. It contains a reference back to the
struct file itself. This makes it difficult for a cifsFileInfo to exist
without a corresponding struct file.
It would be better instead of the cifsFileInfo just held info pertaining
to the open file on the server instead without any back refrences to the
struct file. This would allow it to exist after the filp to which it was
originally attached was closed.
Much of the use of the file pointer in this struct is to get at the
dentry. Begin divorcing the cifsFileInfo from the struct file by
keeping a reference to the dentry. Since the dentry will have a
reference to the inode, we can eliminate the "pInode" field too and
convert the igrab/iput to dget/dput.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Suresh Jayaraman <sjayaraman@suse.de>
Acked-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/cifs/file.c')
-rw-r--r-- | fs/cifs/file.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 80856f180711..c302b9c52644 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c @@ -2335,7 +2335,7 @@ void cifs_oplock_break(struct work_struct *work) { struct cifsFileInfo *cfile = container_of(work, struct cifsFileInfo, oplock_break); - struct inode *inode = cfile->pInode; + struct inode *inode = cfile->dentry->d_inode; struct cifsInodeInfo *cinode = CIFS_I(inode); int rc, waitrc = 0; |