diff options
| author | Jeff Layton <jlayton@redhat.com> | 2012-03-23 14:40:56 -0400 |
|---|---|---|
| committer | Jeff Layton <jlayton@redhat.com> | 2012-03-23 14:40:56 -0400 |
| commit | 597b027f694481ffeebcffe634c24b807198d46c (patch) | |
| tree | 2dce2da017aa89c9e7465014ffa7aced11393b28 /fs/cifs/cifssmb.c | |
| parent | e9492871fb0546f1b73f309d9e8c0f030bfdfdca (diff) | |
| download | blackbird-op-linux-597b027f694481ffeebcffe634c24b807198d46c.tar.gz blackbird-op-linux-597b027f694481ffeebcffe634c24b807198d46c.zip | |
cifs: call cifs_update_eof with i_lock held
cifs_update_eof has the potential to be racy if multiple threads are
trying to modify it at the same time. Protect modifications of the
server_eof value with the inode->i_lock.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Diffstat (limited to 'fs/cifs/cifssmb.c')
| -rw-r--r-- | fs/cifs/cifssmb.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c index 5ec0b90b0444..b63bf5f0698a 100644 --- a/fs/cifs/cifssmb.c +++ b/fs/cifs/cifssmb.c @@ -2044,7 +2044,9 @@ cifs_writev_complete(struct work_struct *work) int i = 0; if (wdata->result == 0) { + spin_lock(&inode->i_lock); cifs_update_eof(CIFS_I(inode), wdata->offset, wdata->bytes); + spin_unlock(&inode->i_lock); cifs_stats_bytes_written(tlink_tcon(wdata->cfile->tlink), wdata->bytes); } else if (wdata->sync_mode == WB_SYNC_ALL && wdata->result == -EAGAIN) |
