diff options
author | Julia Lawall <julia@diku.dk> | 2011-04-01 16:23:46 +0200 |
---|---|---|
committer | James Bottomley <James.Bottomley@suse.de> | 2011-05-01 10:18:31 -0500 |
commit | 5c2dce26fd670607b5ff04f18efa38739805f6d6 (patch) | |
tree | 0664c48fd5610e2905ab849f088f3abeab75ee62 /fs/cifs/cifsglob.h | |
parent | ab6c10b136d5f8eb856a0f17247edc7c19805e1b (diff) | |
download | blackbird-op-linux-5c2dce26fd670607b5ff04f18efa38739805f6d6.tar.gz blackbird-op-linux-5c2dce26fd670607b5ff04f18efa38739805f6d6.zip |
[SCSI] bnx2fc: introduce missing kfree
Error handling code following a kmalloc should free the allocated data.
The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
when != if (...) { <+...x...+> }
(
x->f1 = E
|
(x->f1 == NULL || ...)
|
f(...,x->f1,...)
)
...>
(
return \(0\|<+...x...+>\|ptr\);
|
return@p2 ...;
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Bhanu Prakash Gollapudi <bprakash@broadcom.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'fs/cifs/cifsglob.h')
0 files changed, 0 insertions, 0 deletions