summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorLuca Barbieri <luca@luca-barbieri.com>2010-02-20 11:08:56 +0100
committerBen Skeggs <bskeggs@redhat.com>2010-02-25 15:09:13 +1000
commite32b2c883bfe9b57c660b5db31a62cea96c0c046 (patch)
tree8fb7bc6daac0a63dcfd33a3b39160d8dfaeeb694 /drivers
parent761c5a69751967f4fe7430eb65b3a0ea92f3b673 (diff)
downloadblackbird-op-linux-e32b2c883bfe9b57c660b5db31a62cea96c0c046.tar.gz
blackbird-op-linux-e32b2c883bfe9b57c660b5db31a62cea96c0c046.zip
drm/nouveau: fix missing spin_unlock in failure path
Found by sparse. Signed-off-by: Luca Barbieri <luca@luca-barbieri.com> Signed-off-by: Francisco Jerez <currojerez@riseup.net> Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/gpu/drm/nouveau/nouveau_gem.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c
index fee959c72f40..8265fed528fd 100644
--- a/drivers/gpu/drm/nouveau/nouveau_gem.c
+++ b/drivers/gpu/drm/nouveau/nouveau_gem.c
@@ -558,11 +558,11 @@ nouveau_gem_pushbuf_reloc_apply(struct drm_device *dev,
spin_lock(&nvbo->bo.lock);
ret = ttm_bo_wait(&nvbo->bo, false, false, false);
+ spin_unlock(&nvbo->bo.lock);
if (ret) {
NV_ERROR(dev, "reloc wait_idle failed: %d\n", ret);
break;
}
- spin_unlock(&nvbo->bo.lock);
nouveau_bo_wr32(nvbo, r->reloc_bo_offset >> 2, data);
}
OpenPOWER on IntegriCloud