summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>2013-03-20 12:14:30 +0000
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2013-03-25 00:21:49 +0100
commitcf8df962aa830d05be1a8d5a9c7d2a67b2837b45 (patch)
treea3ce8c148927be8bf3360511d2cd18f464aada97 /drivers
parent2e0f8822d1a6d839e66786e99ce1043e4ad1cd72 (diff)
downloadblackbird-op-linux-cf8df962aa830d05be1a8d5a9c7d2a67b2837b45.tar.gz
blackbird-op-linux-cf8df962aa830d05be1a8d5a9c7d2a67b2837b45.zip
ACPI / LPSS: make code less confusing for reader
The excerpt like this: if (err) { err = 0; goto error_out; } makes a reader confused even if it's commented. Let's do necessary actions and return no error explicitly. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/acpi/acpi_lpss.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
index c87db0e47d09..b1c95422ce74 100644
--- a/drivers/acpi/acpi_lpss.c
+++ b/drivers/acpi/acpi_lpss.c
@@ -150,8 +150,8 @@ static int acpi_lpss_create_device(struct acpi_device *adev,
* Skip the device, but don't terminate the namespace
* scan.
*/
- ret = 0;
- goto err_out;
+ kfree(pdata);
+ return 0;
}
}
OpenPOWER on IntegriCloud