diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2011-01-26 18:08:02 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-01-27 15:02:56 -0800 |
| commit | ccf434380d1a67df2dcb9113206b77d0cb0a1cef (patch) | |
| tree | 1e1a36691f42ed7448f27f71a9ca9445e88ab5f1 /drivers | |
| parent | 065825402c058f4a123ddc53dbbe864cc5caaf64 (diff) | |
| download | blackbird-op-linux-ccf434380d1a67df2dcb9113206b77d0cb0a1cef.tar.gz blackbird-op-linux-ccf434380d1a67df2dcb9113206b77d0cb0a1cef.zip | |
net: fix dev_seq_next()
Commit c6d14c84566d (net: Introduce for_each_netdev_rcu() iterator)
added a race in dev_seq_next().
The rcu_dereference() call should be done _before_ testing the end of
list, or we might return a wrong net_device if a concurrent thread
changes net_device list under us.
Note : discovered thanks to a sparse warning :
net/core/dev.c:3919:9: error: incompatible types in comparison expression
(different address spaces)
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
0 files changed, 0 insertions, 0 deletions
