summaryrefslogtreecommitdiffstats
path: root/drivers/video/backlight
diff options
context:
space:
mode:
authorJiri Kosina <jkosina@suse.cz>2012-07-30 10:40:28 +0200
committerJiri Kosina <jkosina@suse.cz>2012-07-30 10:40:28 +0200
commite1c9ac420ef15e39c2ead879cda1677d1e5cb2b6 (patch)
tree2407e5a6c463e4a4a0e4063fbc4b693aee1362be /drivers/video/backlight
parentd14b7a419a664cd7c1c585c9e7fffee9e9051d53 (diff)
downloadblackbird-op-linux-e1c9ac420ef15e39c2ead879cda1677d1e5cb2b6.tar.gz
blackbird-op-linux-e1c9ac420ef15e39c2ead879cda1677d1e5cb2b6.zip
Revert "backlight: fix memory leak on obscure error path"
This reverts commit 9ea3c498962bc63748e92c31c874169ab0726324. 'data' is being allocated by devm_kzalloc(), is it's actually wrong to free() it in the error path, as it will be destroyed properly later. Reported-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/video/backlight')
-rw-r--r--drivers/video/backlight/88pm860x_bl.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/video/backlight/88pm860x_bl.c b/drivers/video/backlight/88pm860x_bl.c
index f75da8758adc..f49181c73113 100644
--- a/drivers/video/backlight/88pm860x_bl.c
+++ b/drivers/video/backlight/88pm860x_bl.c
@@ -228,7 +228,6 @@ static int pm860x_backlight_probe(struct platform_device *pdev)
data->port = pdata->flags;
if (data->port < 0) {
dev_err(&pdev->dev, "wrong platform data is assigned");
- kfree(data);
return -EINVAL;
}
OpenPOWER on IntegriCloud