diff options
| author | Johan Hovold <johan@kernel.org> | 2017-01-03 16:40:01 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-01-12 11:39:13 +0100 |
| commit | 2a4ae7bc3d8d8e4b92dbac37c90ba1708e7e5c80 (patch) | |
| tree | e4df2a5b3cfa29e17b822263560a9c1afd51230e /drivers/usb | |
| parent | 6ae3e89aa6b1cc3ae129922c7132ffea0aa6b19c (diff) | |
| download | blackbird-op-linux-2a4ae7bc3d8d8e4b92dbac37c90ba1708e7e5c80.tar.gz blackbird-op-linux-2a4ae7bc3d8d8e4b92dbac37c90ba1708e7e5c80.zip | |
USB: serial: quatech2: fix sleep-while-atomic in close
commit f09d1886a41e9063b43da493ef0e845ac8afd2fa upstream.
The write URB was being killed using the synchronous interface while
holding a spin lock in close().
Simply drop the lock and busy-flag update, something which would have
been taken care of by the completion handler if the URB was in flight.
Fixes: f7a33e608d9a ("USB: serial: add quatech2 usb to serial driver")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/serial/quatech2.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c index 85acb50a7ee2..bd1a1307e0f0 100644 --- a/drivers/usb/serial/quatech2.c +++ b/drivers/usb/serial/quatech2.c @@ -408,16 +408,12 @@ static void qt2_close(struct usb_serial_port *port) { struct usb_serial *serial; struct qt2_port_private *port_priv; - unsigned long flags; int i; serial = port->serial; port_priv = usb_get_serial_port_data(port); - spin_lock_irqsave(&port_priv->urb_lock, flags); usb_kill_urb(port_priv->write_urb); - port_priv->urb_in_use = false; - spin_unlock_irqrestore(&port_priv->urb_lock, flags); /* flush the port transmit buffer */ i = usb_control_msg(serial->dev, |
