diff options
| author | Alexander Shishkin <alexander.shishkin@linux.intel.com> | 2012-06-29 17:48:49 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-07-06 10:58:38 -0700 |
| commit | b7283d5a044c010d5e68afccc0598846f254db7b (patch) | |
| tree | b6c77944d2d880bed6845e2f362c1f2c4a8857ce /drivers/usb/chipidea/udc.c | |
| parent | 3d97ff63f8997761f12c8fbe8082996c6eeaba1a (diff) | |
| download | blackbird-op-linux-b7283d5a044c010d5e68afccc0598846f254db7b.tar.gz blackbird-op-linux-b7283d5a044c010d5e68afccc0598846f254db7b.zip | |
usb: chipidea: remove unneeded NULL check
As reported by Dan Carpenter, there is a NULL check in udc_start() that
follows a dereference of the pointer that's being checked. However, at
that point udc pointer shouldn't ever be NULL and if it is, the dereference
should cause an oops.
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Richard Zhao <richard.zhao@freescale.com>
Acked-by: Marek Vasut <marex@denx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/chipidea/udc.c')
| -rw-r--r-- | drivers/usb/chipidea/udc.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 4688ab71bd27..80e71021f186 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c @@ -1648,9 +1648,6 @@ static int udc_start(struct ci13xxx *udc) struct device *dev = udc->dev; int retval = 0; - if (!udc) - return -EINVAL; - spin_lock_init(&udc->lock); udc->gadget.ops = &usb_gadget_ops; |
