diff options
author | Tim Gardner <tim.gardner@canonical.com> | 2011-04-28 11:00:30 -0600 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2011-04-29 08:02:47 +0200 |
commit | c7a7b814c9dca9ee01b38e63b4a46de87156d3b6 (patch) | |
tree | 6cf6ab254dc918d4cedfa6c85b83cd9baa3d236a /drivers/tty/serial/s3c2440.c | |
parent | 64d21fc194e12bdf7347019bf10325a4b3d77e7b (diff) | |
download | blackbird-op-linux-c7a7b814c9dca9ee01b38e63b4a46de87156d3b6.tar.gz blackbird-op-linux-c7a7b814c9dca9ee01b38e63b4a46de87156d3b6.zip |
ioremap: Delay sanity check until after a successful mapping
While tracking down the reason for an ioremap() failure I was
distracted by the WARN_ONCE() in __ioremap_caller().
Performing a WARN_ONCE() sanity check before the mapping
is successful seems pointless if the caller sends bad values.
A case in point is when the BIOS provides erroneous screen_info
values causing vesafb_probe() to request an outrageuous size.
The WARN_ONCE is then wasted on bogosity. Move the warning to a
point where the mapping has been successfully allocated.
Addresses:
http://bugs.launchpad.net/bugs/772042
Reviewed-by: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Link: http://lkml.kernel.org/r/4DB99D2E.9080106@canonical.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'drivers/tty/serial/s3c2440.c')
0 files changed, 0 insertions, 0 deletions