summaryrefslogtreecommitdiffstats
path: root/drivers/target
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2011-07-27 14:11:43 +0300
committerNicholas Bellinger <nab@linux-iscsi.org>2011-07-27 20:28:16 +0000
commit8f50c7f5d63b0e4a29f6f96e8cfaca782e0c458d (patch)
treebc2f8064a1170be3755b4443f813ee50bf85e3fd /drivers/target
parent4a28a3fa8c37193b105807193b3695048f0050a4 (diff)
downloadblackbird-op-linux-8f50c7f5d63b0e4a29f6f96e8cfaca782e0c458d.tar.gz
blackbird-op-linux-8f50c7f5d63b0e4a29f6f96e8cfaca782e0c458d.zip
iscsi-target: strlen() doesn't count the terminator
This patch fixes an off by one check in iscsit_add_tiqn() because the NULL terminator isn't taken into consideration. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target')
-rw-r--r--drivers/target/iscsi/iscsi_target.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
index 14c81c4265bd..396c79d8569c 100644
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c
@@ -120,7 +120,7 @@ struct iscsi_tiqn *iscsit_add_tiqn(unsigned char *buf)
struct iscsi_tiqn *tiqn = NULL;
int ret;
- if (strlen(buf) > ISCSI_IQN_LEN) {
+ if (strlen(buf) >= ISCSI_IQN_LEN) {
pr_err("Target IQN exceeds %d bytes\n",
ISCSI_IQN_LEN);
return ERR_PTR(-EINVAL);
OpenPOWER on IntegriCloud