diff options
| author | Nicholas Bellinger <nab@linux-iscsi.org> | 2012-02-13 02:35:01 -0800 |
|---|---|---|
| committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2012-02-25 14:37:49 -0800 |
| commit | ffc32d5259d107a3aa1b822e22f20b69cb9ec0a5 (patch) | |
| tree | 770ec5b87b91c9c1bc7edd76c8a1535259424696 /drivers/target | |
| parent | 86715569d085addc635c2b55ee8acb79d3a7fbbf (diff) | |
| download | blackbird-op-linux-ffc32d5259d107a3aa1b822e22f20b69cb9ec0a5.tar.gz blackbird-op-linux-ffc32d5259d107a3aa1b822e22f20b69cb9ec0a5.zip | |
target: Make target_release_cmd_kref release on empty list
This patch changes target_release_cmd_kref() to make TFO->release_cmd()
call when list_empty(&se_cmd->se_cmd_list) is TRUE. This is required
for TMR_ABORT_TASK operation where the referenced tag descriptor may
have already been pulled of the session command list.
Reported-by: Roland Dreier <roland@purestorage.com>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target')
| -rw-r--r-- | drivers/target/target_core_transport.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index c6b8b8233399..52a66710a293 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -4051,7 +4051,7 @@ static void target_release_cmd_kref(struct kref *kref) spin_lock_irqsave(&se_sess->sess_cmd_lock, flags); if (list_empty(&se_cmd->se_cmd_list)) { spin_unlock_irqrestore(&se_sess->sess_cmd_lock, flags); - WARN_ON(1); + se_cmd->se_tfo->release_cmd(se_cmd); return; } if (se_sess->sess_tearing_down && se_cmd->cmd_wait_set) { |
