diff options
| author | Hans Verkuil <hverkuil@xs4all.nl> | 2016-07-22 05:36:29 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@s-opensource.com> | 2016-07-28 20:16:35 -0300 |
| commit | 292eaf50c7df4ae2ae8aaa9e1ce3f1240a353ee8 (patch) | |
| tree | 2f15beb3e5ff2268fda5c96b62916a2d3ee6701e /drivers/staging | |
| parent | cd70c37b5a23eee7aa411205e2b4c74097f52336 (diff) | |
| download | blackbird-op-linux-292eaf50c7df4ae2ae8aaa9e1ce3f1240a353ee8.tar.gz blackbird-op-linux-292eaf50c7df4ae2ae8aaa9e1ce3f1240a353ee8.zip | |
[media] cec: fix off-by-one memset
The unused bytes of the features array should be zeroed, but the start index was one
byte too early. This caused the device features byte to be overwritten by 0.
The compliance test for the CEC_S_LOG_ADDRS ioctl didn't catch this because it tested
byte continuation with the second device features byte being 0 :-(
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/staging')
| -rw-r--r-- | drivers/staging/media/cec/cec-adap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/media/cec/cec-adap.c b/drivers/staging/media/cec/cec-adap.c index 9fffddb7ac7e..b2393bbacb26 100644 --- a/drivers/staging/media/cec/cec-adap.c +++ b/drivers/staging/media/cec/cec-adap.c @@ -1252,7 +1252,7 @@ int __cec_s_log_addrs(struct cec_adapter *adap, return -EINVAL; } /* Zero unused part of the feature array */ - memset(features + i, 0, feature_sz - i); + memset(features + i + 1, 0, feature_sz - i - 1); } if (log_addrs->cec_version >= CEC_OP_CEC_VERSION_2_0) { |
