diff options
author | Jiri Slaby <jslaby@suse.cz> | 2014-04-14 09:46:50 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-04-17 12:23:06 -0700 |
commit | a94cdd1f4d30f12904ab528152731fb13a812a16 (patch) | |
tree | 2b1b076a076e9edecfd52d2a3b784a25bf1e4260 /drivers/sfi | |
parent | c9eaa447e77efe77b7fa4c953bd62de8297fd6c5 (diff) | |
download | blackbird-op-linux-a94cdd1f4d30f12904ab528152731fb13a812a16.tar.gz blackbird-op-linux-a94cdd1f4d30f12904ab528152731fb13a812a16.zip |
Char: ipmi_bt_sm, fix infinite loop
In read_all_bytes, we do
unsigned char i;
...
bt->read_data[0] = BMC2HOST;
bt->read_count = bt->read_data[0];
...
for (i = 1; i <= bt->read_count; i++)
bt->read_data[i] = BMC2HOST;
If bt->read_data[0] == bt->read_count == 255, we loop infinitely in the
'for' loop. Make 'i' an 'int' instead of 'char' to get rid of the
overflow and finish the loop after 255 iterations every time.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Reported-and-debugged-by: Rui Hui Dian <rhdian@novell.com>
Cc: Tomas Cech <tcech@suse.cz>
Cc: Corey Minyard <minyard@acm.org>
Cc: <openipmi-developer@lists.sourceforge.net>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/sfi')
0 files changed, 0 insertions, 0 deletions