summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/ibmvscsi
diff options
context:
space:
mode:
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>2012-07-30 11:33:05 +1000
committerJames Bottomley <JBottomley@Parallels.com>2012-09-24 12:11:09 +0400
commit225c56960fcafeccc2b6304f96cd3f0dbf42a16a (patch)
tree3e3518154a0c329f776ae981b522b2f215c00372 /drivers/scsi/ibmvscsi
parent9965c2f19be470c452357ae4f6304467cdeada55 (diff)
downloadblackbird-op-linux-225c56960fcafeccc2b6304f96cd3f0dbf42a16a.tar.gz
blackbird-op-linux-225c56960fcafeccc2b6304f96cd3f0dbf42a16a.zip
[SCSI] ibmvscsi: Fix host config length field overflow
The length field in the host config packet is only 16-bit long, so passing it 0x10000 (64K which is our standard PAGE_SIZE) doesn't work and result in an empty config from the server. Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: <stable@vger.kernel.org> Acked-by: Robert Jennings <rcj@linux.vnet.ibm.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/ibmvscsi')
-rw-r--r--drivers/scsi/ibmvscsi/ibmvscsi.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index a8462176ee57..ef9a54c7da67 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -1851,6 +1851,9 @@ static int ibmvscsi_do_host_config(struct ibmvscsi_host_data *hostdata,
host_config = &evt_struct->iu.mad.host_config;
+ /* The transport length field is only 16-bit */
+ length = min(0xffff, length);
+
/* Set up a lun reset SRP command */
memset(host_config, 0x00, sizeof(*host_config));
host_config->common.type = VIOSRP_HOST_CONFIG_TYPE;
OpenPOWER on IntegriCloud