diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2011-09-26 09:23:37 +0300 |
---|---|---|
committer | James Bottomley <JBottomley@Parallels.com> | 2011-12-15 10:57:31 +0400 |
commit | 4053a4be525d3441cad6cd1ae207177f03eb9ce7 (patch) | |
tree | 081b70eb50643040b85104aa652533ad07fa5379 /drivers/scsi/FlashPoint.c | |
parent | 7af0abbc2ffcae601ea14e39048901833528f104 (diff) | |
download | blackbird-op-linux-4053a4be525d3441cad6cd1ae207177f03eb9ce7.tar.gz blackbird-op-linux-4053a4be525d3441cad6cd1ae207177f03eb9ce7.zip |
[SCSI] be2iscsi: cleanup a min_t() call
"sense_len" was declared as int type but actually it only stores a
u16 value that comes from hardware. The cast to u16 in min_t()
confuses static analysis because it truncates the int to u16 so I've
fixed the declaration to reflect that "sense_len" is just a u16.
Also there was a call to cpu_to_be16() which I've changed to
be16_to_cpu(). The functions are equivalent, but obviously the
hardware is big endian and we're doing the min_t() comparison on CPU
endian values.
This whole patch is just a cleanup and doesn't affect how the code
works.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Acked-by: Jayamohan Kallickal <Jayamohan.kallickal@emulex.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/FlashPoint.c')
0 files changed, 0 insertions, 0 deletions