summaryrefslogtreecommitdiffstats
path: root/drivers/net
diff options
context:
space:
mode:
authorRoel Kluin <12o3l@tiscali.nl>2008-04-17 22:35:54 +0200
committerFrancois Romieu <romieu@fr.zoreil.com>2008-04-17 22:35:54 +0200
commitcee60c377de6d9d10f0a2876794149bd79a15020 (patch)
treeb8427126eea66f0957fee5cd6f785b60c8f4cdd5 /drivers/net
parent4b119e21d0c66c22e8ca03df05d9de623d0eb50f (diff)
downloadblackbird-op-linux-cee60c377de6d9d10f0a2876794149bd79a15020.tar.gz
blackbird-op-linux-cee60c377de6d9d10f0a2876794149bd79a15020.zip
r8169: fix past rtl_chip_info array size for unknown chipsets
'i' is unsigned. Signed-off-by: Roel Kluin <12o3l@tiscali.nl> Acked-by: Francois Romieu <romieu@fr.zoreil.com>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/r8169.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 3acfeeabdee1..5e8ad634490f 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -1705,18 +1705,18 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
rtl8169_print_mac_version(tp);
- for (i = ARRAY_SIZE(rtl_chip_info) - 1; i >= 0; i--) {
+ for (i = 0; i < ARRAY_SIZE(rtl_chip_info); i++) {
if (tp->mac_version == rtl_chip_info[i].mac_version)
break;
}
- if (i < 0) {
+ if (i == ARRAY_SIZE(rtl_chip_info)) {
/* Unknown chip: assume array element #0, original RTL-8169 */
if (netif_msg_probe(tp)) {
dev_printk(KERN_DEBUG, &pdev->dev,
"unknown chip version, assuming %s\n",
rtl_chip_info[0].name);
}
- i++;
+ i = 0;
}
tp->chipset = i;
OpenPOWER on IntegriCloud