diff options
| author | Stefano Brivio <stefano.brivio@polimi.it> | 2007-11-06 22:48:45 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-01-28 15:04:30 -0800 |
| commit | db9683fb19a0f0da1cb4c296ffe1a8db03333cbc (patch) | |
| tree | 86f2c14df0e7cce871d52df687c3b59ccaab1673 /drivers/net/wireless/b43legacy/rfkill.h | |
| parent | 33a3dc9328ce3a89d3490a47197851f5dac4b6b5 (diff) | |
| download | blackbird-op-linux-db9683fb19a0f0da1cb4c296ffe1a8db03333cbc.tar.gz blackbird-op-linux-db9683fb19a0f0da1cb4c296ffe1a8db03333cbc.zip | |
b43legacy: rewrite and fix rfkill initialization
The rfkill subsystem doesn't like code like that
rfkill_allocate();
rfkill_register();
rfkill_unregister();
rfkill_register(); /* <- This will crash */
This sequence happens with
modprobe b43
ifconfig wlanX up
ifconfig wlanX down
ifconfig wlanX up
Fix this by always re-allocating the rfkill stuff before register.
The patch to b43 by Michael Buesch <mb@bu3sch.de> has been ported to
b43legacy.
Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/b43legacy/rfkill.h')
| -rw-r--r-- | drivers/net/wireless/b43legacy/rfkill.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/net/wireless/b43legacy/rfkill.h b/drivers/net/wireless/b43legacy/rfkill.h index b68215e788e2..11150a8032f0 100644 --- a/drivers/net/wireless/b43legacy/rfkill.h +++ b/drivers/net/wireless/b43legacy/rfkill.h @@ -16,14 +16,14 @@ struct b43legacy_rfkill { struct rfkill *rfkill; /* The poll device for the RFKILL input button */ struct input_polled_dev *poll_dev; + /* Did initialization succeed? Used for freeing. */ + bool registered; /* The unique name of this rfkill switch */ - char name[32]; + char name[sizeof("b43legacy-phy4294967295")]; }; -/* All the init functions return void, because we are not interested +/* The init function returns void, because we are not interested * in failing the b43 init process when rfkill init failed. */ -void b43legacy_rfkill_alloc(struct b43legacy_wldev *dev); -void b43legacy_rfkill_free(struct b43legacy_wldev *dev); void b43legacy_rfkill_init(struct b43legacy_wldev *dev); void b43legacy_rfkill_exit(struct b43legacy_wldev *dev); |
