diff options
author | Joe Perches <joe@perches.com> | 2012-06-04 12:44:16 +0000 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-06-06 09:31:33 -0700 |
commit | 6469933605a3ecdfa66b98160cde98ecd256cb3f (patch) | |
tree | 9d80273c26cbec4b3064eee47ba173be11ac444f /drivers/net/ethernet/sun | |
parent | 20d5ec435c5fba8142eb7df692a5f54fbb26e892 (diff) | |
download | blackbird-op-linux-6469933605a3ecdfa66b98160cde98ecd256cb3f.tar.gz blackbird-op-linux-6469933605a3ecdfa66b98160cde98ecd256cb3f.zip |
ethernet: Remove casts to same type
Adding casts of objects to the same type is unnecessary
and confusing for a human reader.
For example, this cast:
int y;
int *p = (int *)&y;
I used the coccinelle script below to find and remove these
unnecessary casts. I manually removed the conversions this
script produces of casts with __force, __iomem and __user.
@@
type T;
T *p;
@@
- (T *)p
+ p
A function in atl1e_main.c was passed a const pointer
when it actually modified elements of the structure.
Change the argument to a non-const pointer.
A function in stmmac needed a __force to avoid a sparse
warning. Added it.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/sun')
-rw-r--r-- | drivers/net/ethernet/sun/sunqe.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/sun/sunqe.c b/drivers/net/ethernet/sun/sunqe.c index 7d4a040d84a2..aeded7ff1c8f 100644 --- a/drivers/net/ethernet/sun/sunqe.c +++ b/drivers/net/ethernet/sun/sunqe.c @@ -441,7 +441,7 @@ static void qe_rx(struct sunqe *qep) } else { skb_reserve(skb, 2); skb_put(skb, len); - skb_copy_to_linear_data(skb, (unsigned char *) this_qbuf, + skb_copy_to_linear_data(skb, this_qbuf, len); skb->protocol = eth_type_trans(skb, qep->dev); netif_rx(skb); |