diff options
| author | Emil Tantilov <emil.s.tantilov@intel.com> | 2013-05-29 06:23:10 +0000 |
|---|---|---|
| committer | Jeff Kirsher <jeffrey.t.kirsher@intel.com> | 2013-07-30 17:56:04 -0700 |
| commit | a4b6fc6bc61e6aeb24af73c5b195a6aec27d88ff (patch) | |
| tree | 8f48363c496ddb5fa8cce721f3c539ae701c5159 /drivers/net/ethernet/intel/ixgbe/ixgbe.h | |
| parent | 3dcc2f4142610cc7212a757348d45f1e815927c9 (diff) | |
| download | blackbird-op-linux-a4b6fc6bc61e6aeb24af73c5b195a6aec27d88ff.tar.gz blackbird-op-linux-a4b6fc6bc61e6aeb24af73c5b195a6aec27d88ff.zip | |
ixgbe: fix SFF data dumps of SFP+ modules
This patch fixes several issues with the previous implementation of the
SFF data dump of SFP+ modules:
- removed the __IXGBE_READ_I2C flag - I2C access locking is handled in the
HW specific routines
- fixed the read loop to read data from ee->offset to ee->len
- the reads fail if __IXGBE_IN_SFP_INIT is set in the process - this is
needed because on some HW I2C operations can take long time and disrupt
the SFP and link detection process
Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
Reported-by: Ben Hutchings <bhutchings@solarflare.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/ixgbe/ixgbe.h')
| -rw-r--r-- | drivers/net/ethernet/intel/ixgbe/ixgbe.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h index 7be725cdfea8..d882278851d7 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h @@ -754,7 +754,6 @@ enum ixgbe_state_t { __IXGBE_DOWN, __IXGBE_SERVICE_SCHED, __IXGBE_IN_SFP_INIT, - __IXGBE_READ_I2C, }; struct ixgbe_cb { |
