summaryrefslogtreecommitdiffstats
path: root/drivers/mfd
diff options
context:
space:
mode:
authorLinus Walleij <linus.walleij@linaro.org>2015-12-22 15:47:55 +0100
committerLee Jones <lee.jones@linaro.org>2016-01-14 08:43:21 +0000
commit2d5f72b85a8876088be77cee3a7bdee4c0259085 (patch)
treed513cdc0d5aa58f2a6fdf14b4cafc13e27d62cc9 /drivers/mfd
parentbf3de47f1af3dab8fb8c3a3bd21ada7de614b7de (diff)
downloadblackbird-op-linux-2d5f72b85a8876088be77cee3a7bdee4c0259085.tar.gz
blackbird-op-linux-2d5f72b85a8876088be77cee3a7bdee4c0259085.zip
mfd: tc6393xb: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Cc: Dmitry Baryshkov <dbaryshkov@gmail.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd')
-rw-r--r--drivers/mfd/tc6393xb.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mfd/tc6393xb.c b/drivers/mfd/tc6393xb.c
index 8c84a513016b..1ecbfa40d1b3 100644
--- a/drivers/mfd/tc6393xb.c
+++ b/drivers/mfd/tc6393xb.c
@@ -437,8 +437,8 @@ static int tc6393xb_gpio_get(struct gpio_chip *chip,
struct tc6393xb *tc6393xb = container_of(chip, struct tc6393xb, gpio);
/* XXX: does dsr also represent inputs? */
- return tmio_ioread8(tc6393xb->scr + SCR_GPO_DSR(offset / 8))
- & TC_GPIO_BIT(offset);
+ return !!(tmio_ioread8(tc6393xb->scr + SCR_GPO_DSR(offset / 8))
+ & TC_GPIO_BIT(offset));
}
static void __tc6393xb_gpio_set(struct gpio_chip *chip,
OpenPOWER on IntegriCloud