diff options
| author | Kent Overstreet <koverstreet@google.com> | 2013-04-26 15:39:55 -0700 |
|---|---|---|
| committer | Kent Overstreet <koverstreet@google.com> | 2013-06-26 17:09:15 -0700 |
| commit | c37511b863f36c1cc6e18440717fd4cc0e881b8a (patch) | |
| tree | 64d82c648bd092f38c35c4b808411bc1cdb3a9f0 /drivers/md/bcache/super.c | |
| parent | 5794351146199b9ac67a5ab1beab82be8bfd7b5d (diff) | |
| download | blackbird-op-linux-c37511b863f36c1cc6e18440717fd4cc0e881b8a.tar.gz blackbird-op-linux-c37511b863f36c1cc6e18440717fd4cc0e881b8a.zip | |
bcache: Fix/revamp tracepoints
The tracepoints were reworked to be more sensible, and fixed a null
pointer deref in one of the tracepoints.
Converted some of the pr_debug()s to tracepoints - this is partly a
performance optimization; it used to be that with DEBUG or
CONFIG_DYNAMIC_DEBUG pr_debug() was an empty macro; but at some point it
was changed to an empty inline function.
Some of the pr_debug() statements had rather expensive function calls as
part of the arguments, so this code was getting run unnecessarily even
on non debug kernels - in some fast paths, too.
Signed-off-by: Kent Overstreet <koverstreet@google.com>
Diffstat (limited to 'drivers/md/bcache/super.c')
| -rw-r--r-- | drivers/md/bcache/super.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index e53f89988b08..47bc13745068 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -11,6 +11,7 @@ #include "debug.h" #include "request.h" +#include <linux/blkdev.h> #include <linux/buffer_head.h> #include <linux/debugfs.h> #include <linux/genhd.h> @@ -543,7 +544,6 @@ void bch_prio_write(struct cache *ca) pr_debug("free %zu, free_inc %zu, unused %zu", fifo_used(&ca->free), fifo_used(&ca->free_inc), fifo_used(&ca->unused)); - blktrace_msg(ca, "Starting priorities: " buckets_free(ca)); for (i = prio_buckets(ca) - 1; i >= 0; --i) { long bucket; |
