summaryrefslogtreecommitdiffstats
path: root/drivers/isdn
diff options
context:
space:
mode:
authorTilman Schmidt <tilman@imap.cc>2014-10-11 13:46:29 +0200
committerDavid S. Miller <davem@davemloft.net>2014-10-14 15:05:33 -0400
commit1bdc07ebabefd19b56d1d36584a401ff6085fa71 (patch)
treee4e86e5af2cd01010b3f26608bc863682015d2c3 /drivers/isdn
parentf787d6c8dd52ded9874cbbc447a32515c80fa2bf (diff)
downloadblackbird-op-linux-1bdc07ebabefd19b56d1d36584a401ff6085fa71.tar.gz
blackbird-op-linux-1bdc07ebabefd19b56d1d36584a401ff6085fa71.zip
isdn/gigaset: missing break in do_facility_req
If we take the unsupported supplementary service notification mask path, we end up falling through and overwriting the error code. Insert a break statement to skip the remainder of the switch case and proceed to sending the reply message. Spotted with Coverity. Reported-by: Dave Jones <davej@redhat.com> Signed-off-by: Tilman Schmidt <tilman@imap.cc> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/isdn')
-rw-r--r--drivers/isdn/gigaset/capi.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/isdn/gigaset/capi.c b/drivers/isdn/gigaset/capi.c
index 3286903a95d2..a2eabe97deea 100644
--- a/drivers/isdn/gigaset/capi.c
+++ b/drivers/isdn/gigaset/capi.c
@@ -1180,6 +1180,7 @@ static void do_facility_req(struct gigaset_capi_ctr *iif,
confparam[3] = 2; /* length */
capimsg_setu16(confparam, 4,
CapiSupplementaryServiceNotSupported);
+ break;
}
info = CapiSuccess;
confparam[3] = 2; /* length */
OpenPOWER on IntegriCloud