summaryrefslogtreecommitdiffstats
path: root/drivers/hwmon/lm63.c
diff options
context:
space:
mode:
authorJean Delvare <khali@linux-fr.org>2013-07-08 14:18:24 +0200
committerJean Delvare <khali@endymion.delvare>2013-07-08 14:18:24 +0200
commit5b0620df9c38438ee245a97b8102ed74556e5505 (patch)
tree0a54591c5999ed7522fb4c253aa927ce885f9dce /drivers/hwmon/lm63.c
parent78c2c2fe59b8c6b7d20e163efde0bfccc679f647 (diff)
downloadblackbird-op-linux-5b0620df9c38438ee245a97b8102ed74556e5505.tar.gz
blackbird-op-linux-5b0620df9c38438ee245a97b8102ed74556e5505.zip
hwmon: (lm63) Drop redundant safety on cache lifetime
time_after (as opposed to time_after_equal) already ensures that the cache lifetime is at least as much as requested. There is no point in manually adding another jiffy to that value, and this can confuse the reader into wrong interpretation. Signed-off-by: Jean Delvare <khali@linux-fr.org> Cc: Imre Deak <imre.deak@intel.com>
Diffstat (limited to 'drivers/hwmon/lm63.c')
-rw-r--r--drivers/hwmon/lm63.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/hwmon/lm63.c b/drivers/hwmon/lm63.c
index f644a2e57599..d0def50ea860 100644
--- a/drivers/hwmon/lm63.c
+++ b/drivers/hwmon/lm63.c
@@ -247,9 +247,8 @@ static struct lm63_data *lm63_update_device(struct device *dev)
mutex_lock(&data->update_lock);
- next_update = data->last_updated
- + msecs_to_jiffies(data->update_interval) + 1;
-
+ next_update = data->last_updated +
+ msecs_to_jiffies(data->update_interval);
if (time_after(jiffies, next_update) || !data->valid) {
if (data->config & 0x04) { /* tachometer enabled */
/* order matters for fan1_input */
OpenPOWER on IntegriCloud