summaryrefslogtreecommitdiffstats
path: root/drivers/hwmon/emc1403.c
diff options
context:
space:
mode:
authorJosef Gajdusek <atx@atx.name>2014-05-11 14:40:44 +0200
committerGuenter Roeck <linux@roeck-us.net>2014-05-12 08:37:05 -0700
commit17c048fc4bd95efea208a1920f169547d8588f1f (patch)
tree72cb225e6ddc4827398ba4edc244daf6e70f9e82 /drivers/hwmon/emc1403.c
parentd6d211db37e75de2ddc3a4f979038c40df7cc79c (diff)
downloadblackbird-op-linux-17c048fc4bd95efea208a1920f169547d8588f1f.tar.gz
blackbird-op-linux-17c048fc4bd95efea208a1920f169547d8588f1f.zip
hwmon: (emc1403) fix inverted store_hyst()
Attempts to set the hysteresis value to a temperature below the target limit fails with "write error: Numerical result out of range" due to an inverted comparison. Signed-off-by: Josef Gajdusek <atx@atx.name> Reviewed-by: Jean Delvare <jdelvare@suse.de> Cc: stable@vger.kernel.org [Guenter Roeck: Updated headline and description] Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/emc1403.c')
-rw-r--r--drivers/hwmon/emc1403.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/emc1403.c b/drivers/hwmon/emc1403.c
index 90ec1173b8a1..61d89d6d58fe 100644
--- a/drivers/hwmon/emc1403.c
+++ b/drivers/hwmon/emc1403.c
@@ -163,7 +163,7 @@ static ssize_t store_hyst(struct device *dev,
if (retval < 0)
goto fail;
- hyst = val - retval * 1000;
+ hyst = retval * 1000 - val;
hyst = DIV_ROUND_CLOSEST(hyst, 1000);
if (hyst < 0 || hyst > 255) {
retval = -ERANGE;
OpenPOWER on IntegriCloud