diff options
| author | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2012-02-17 10:46:00 -0800 |
|---|---|---|
| committer | Grant Likely <grant.likely@secretlab.ca> | 2012-03-05 08:05:08 -0700 |
| commit | e4e449e82871c53ef3b22bd3a50fceabc0638926 (patch) | |
| tree | 87e14ac729928d7e1c54e7a975b365714c50bf85 /drivers/gpio/gpiolib.c | |
| parent | 25553ff0756c59b617af6bdd280c94e943164184 (diff) | |
| download | blackbird-op-linux-e4e449e82871c53ef3b22bd3a50fceabc0638926.tar.gz blackbird-op-linux-e4e449e82871c53ef3b22bd3a50fceabc0638926.zip | |
gpiolib: Add comments explaining the _cansleep() WARN_ON()s
I've seen users getting very confused by the WARN_ON()s for can_sleep
GPIOs in the atomic-safe paths, the discoverability of the non-atomic
version of the API seems to be hampered by the fact that it's defined
in a header file not the .c file where the warnings are.
Add a couple of comments next to the warnings to help people on their
way.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Reviwed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Diffstat (limited to 'drivers/gpio/gpiolib.c')
| -rw-r--r-- | drivers/gpio/gpiolib.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 58f40dfc5265..5a75510d66bb 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1581,6 +1581,7 @@ int __gpio_get_value(unsigned gpio) int value; chip = gpio_to_chip(gpio); + /* Should be using gpio_get_value_cansleep() */ WARN_ON(chip->can_sleep); value = chip->get ? chip->get(chip, gpio - chip->base) : 0; trace_gpio_value(gpio, 1, value); @@ -1653,6 +1654,7 @@ void __gpio_set_value(unsigned gpio, int value) struct gpio_chip *chip; chip = gpio_to_chip(gpio); + /* Should be using gpio_set_value_cansleep() */ WARN_ON(chip->can_sleep); trace_gpio_value(gpio, 0, value); if (test_bit(FLAG_OPEN_DRAIN, &gpio_desc[gpio].flags)) |
