summaryrefslogtreecommitdiffstats
path: root/drivers/firmware
diff options
context:
space:
mode:
authorMatt Fleming <matt.fleming@intel.com>2012-10-23 12:41:03 +0100
committerMatt Fleming <matt.fleming@intel.com>2012-10-30 10:39:28 +0000
commitaeeaa8d46aa38c9cc5fac23feb9b1f91bdbf5dd3 (patch)
tree1072c7445eb10b5a9b417c2eabfb6fa8746ed06c /drivers/firmware
parent07b1c5bc64cff9c880261a1fef562ef7ea7f6575 (diff)
downloadblackbird-op-linux-aeeaa8d46aa38c9cc5fac23feb9b1f91bdbf5dd3.tar.gz
blackbird-op-linux-aeeaa8d46aa38c9cc5fac23feb9b1f91bdbf5dd3.zip
efivarfs: Return a consistent error when efivarfs_get_inode() fails
Instead of returning -ENOSPC if efivarfs_get_inode() fails we should be returning -ENOMEM, since running out of memory is the only reason it can fail. Furthermore, that's the error value used everywhere else in this file. It's also less likely to confuse users that hit this error case. Acked-by: Jeremy Kerr <jeremy.kerr@canonical.com> Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Diffstat (limited to 'drivers/firmware')
-rw-r--r--drivers/firmware/efivars.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index 6a858d1a5bb3..58cec627a821 100644
--- a/drivers/firmware/efivars.c
+++ b/drivers/firmware/efivars.c
@@ -911,7 +911,7 @@ static int efivarfs_create(struct inode *dir, struct dentry *dentry,
inode = efivarfs_get_inode(dir->i_sb, dir, mode, 0);
if (!inode)
- return -ENOSPC;
+ return -ENOMEM;
var = kzalloc(sizeof(struct efivar_entry), GFP_KERNEL);
if (!var) {
OpenPOWER on IntegriCloud