diff options
author | Masahiro Yamada <yamada.masahiro@socionext.com> | 2019-03-28 20:34:25 +0100 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2019-03-29 07:34:59 +0100 |
commit | e8d368ad20f514dce86a64931fe4a6f06a0a6703 (patch) | |
tree | 141af9d224b76b639f619407ad5f71dcc918cc71 /drivers/firmware/efi/test/efi_test.h | |
parent | 1a9df9e29c2afecf6e3089442d429b377279ca3c (diff) | |
download | blackbird-op-linux-e8d368ad20f514dce86a64931fe4a6f06a0a6703.tar.gz blackbird-op-linux-e8d368ad20f514dce86a64931fe4a6f06a0a6703.zip |
efi/libstub: Refactor the cmd_stubcopy Makefile command
It took me a while to understand what is going on in the nested
if-blocks.
Simplify it by removing unneeded code.
- if_changed automatically adds 'set -e', so any failure in the
series of commands makes it immediately fail as a whole.
So, the outer if block is entirely redundant.
- Since commit 9c2af1c7377a ("kbuild: add .DELETE_ON_ERROR special target"),
GNU Make automatically deletes the target on any failure
in its recipe. The explicit 'rm -f $@' is redundant.
- Surrounding commands with ( ) will spawn a subshell to execute them
in it, but it is rarely useful to do so.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Link: http://lkml.kernel.org/r/20190328193429.21373-2-ard.biesheuvel@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'drivers/firmware/efi/test/efi_test.h')
0 files changed, 0 insertions, 0 deletions