summaryrefslogtreecommitdiffstats
path: root/drivers/edac/i7300_edac.c
diff options
context:
space:
mode:
authorJean Delvare <jdelvare@suse.de>2014-02-24 09:39:27 +0100
committerBorislav Petkov <bp@suse.de>2014-02-25 08:54:45 +0100
commitc0f5eeed0f4cef4f05b74883a7160e7edde58b6a (patch)
treed0e481c5bf067bca00bf0fac156c08a07c2d24c7 /drivers/edac/i7300_edac.c
parentcfbf8d4857c26a8a307fb7cd258074c9dcd8c691 (diff)
downloadblackbird-op-linux-c0f5eeed0f4cef4f05b74883a7160e7edde58b6a.tar.gz
blackbird-op-linux-c0f5eeed0f4cef4f05b74883a7160e7edde58b6a.zip
i7core_edac: Fix PCI device reference count
The reference count changes done by pci_get_device can be a little misleading when the usage diverges from the most common scheme. The reference count of the device passed as the last parameter is always decreased, even if the function returns no new device. So if we are going to try alternative device IDs, we must manually increment the device reference count before each retry. If we don't, we end up decreasing the reference count, and after a few modprobe/rmmod cycles the PCI devices will vanish. In other words and as Alan put it: without this fix the EDAC code corrupts the PCI device list. This fixes kernel bug #50491: https://bugzilla.kernel.org/show_bug.cgi?id=50491 Signed-off-by: Jean Delvare <jdelvare@suse.de> Link: http://lkml.kernel.org/r/20140224093927.7659dd9d@endymion.delvare Reviewed-by: Alan Cox <alan@linux.intel.com> Cc: Mauro Carvalho Chehab <m.chehab@samsung.com> Cc: Doug Thompson <dougthompson@xmission.com> Cc: stable@vger.kernel.org Signed-off-by: Borislav Petkov <bp@suse.de>
Diffstat (limited to 'drivers/edac/i7300_edac.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud