diff options
| author | Emilio López <emilio@elopez.com.ar> | 2013-09-20 22:03:10 -0300 |
|---|---|---|
| committer | Maxime Ripard <maxime.ripard@free-electrons.com> | 2013-11-10 11:39:46 +0100 |
| commit | c518e84c76e12e12a2a3404a293b2465af9be5f8 (patch) | |
| tree | 87db4e2a7da53dab70523eb037e05190cfcc842b /drivers/clk/sunxi/clk-factors.c | |
| parent | 107f3198fd2c5902b9cc54c86a0c86f815c173e2 (diff) | |
| download | blackbird-op-linux-c518e84c76e12e12a2a3404a293b2465af9be5f8.tar.gz blackbird-op-linux-c518e84c76e12e12a2a3404a293b2465af9be5f8.zip | |
clk: sunxi: factors: fix off-by-one masks
The previous code would generate one bit too long masks, and was
needlessly complicated. This patch replaces it by simpler code that can
generate the masks correctly.
Signed-off-by: Emilio López <emilio@elopez.com.ar>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Diffstat (limited to 'drivers/clk/sunxi/clk-factors.c')
| -rw-r--r-- | drivers/clk/sunxi/clk-factors.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/clk/sunxi/clk-factors.c b/drivers/clk/sunxi/clk-factors.c index 88523f91d9b7..5687ac9bd85a 100644 --- a/drivers/clk/sunxi/clk-factors.c +++ b/drivers/clk/sunxi/clk-factors.c @@ -40,7 +40,7 @@ struct clk_factors { #define to_clk_factors(_hw) container_of(_hw, struct clk_factors, hw) -#define SETMASK(len, pos) (((-1U) >> (31-len)) << (pos)) +#define SETMASK(len, pos) (((1U << (len)) - 1) << (pos)) #define CLRMASK(len, pos) (~(SETMASK(len, pos))) #define FACTOR_GET(bit, len, reg) (((reg) & SETMASK(len, bit)) >> (bit)) |
