summaryrefslogtreecommitdiffstats
path: root/drivers/clk/imx
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2015-10-21 22:41:39 +0200
committerStephen Boyd <sboyd@codeaurora.org>2015-10-21 16:16:34 -0700
commit489e5d4152c7bdcff8b0bbf73e90d1d59bbec863 (patch)
tree1ae33eed81713ba1637a5cfad44ebdc7c164be28 /drivers/clk/imx
parent77cb8ee67582ad815310c4544c7c408056fe59bf (diff)
downloadblackbird-op-linux-489e5d4152c7bdcff8b0bbf73e90d1d59bbec863.tar.gz
blackbird-op-linux-489e5d4152c7bdcff8b0bbf73e90d1d59bbec863.zip
clk: imx31: add missing of_node_put
for_each_compatible_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ local idexpression n; expression e; @@ for_each_compatible_node(n,...) { ... ( of_node_put(n); | e = n | + of_node_put(n); ? break; ) ... } ... when != n // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Diffstat (limited to 'drivers/clk/imx')
-rw-r--r--drivers/clk/imx/clk-imx31.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/clk/imx/clk-imx31.c b/drivers/clk/imx/clk-imx31.c
index f65b8b1a974a..6a964144a5b5 100644
--- a/drivers/clk/imx/clk-imx31.c
+++ b/drivers/clk/imx/clk-imx31.c
@@ -233,8 +233,10 @@ int __init mx31_clocks_init_dt(void)
if (!of_device_is_compatible(np, "fsl,imx-osc26m"))
continue;
- if (!of_property_read_u32(np, "clock-frequency", &fref))
+ if (!of_property_read_u32(np, "clock-frequency", &fref)) {
+ of_node_put(np);
break;
+ }
}
_mx31_clocks_init(fref);
OpenPOWER on IntegriCloud