diff options
author | Peter Hurley <peter@hurleysoftware.com> | 2014-02-09 20:59:24 -0500 |
---|---|---|
committer | Marcel Holtmann <marcel@holtmann.org> | 2014-02-14 13:39:32 -0800 |
commit | 8981be9b2fe5553af35a43865d9ab4271c3aa2e2 (patch) | |
tree | 717062972b1186decc17184b29b9e7ecce80cde3 /drivers/bluetooth | |
parent | b16b4351313fb89ccb4c227d432d16aa32ffec72 (diff) | |
download | blackbird-op-linux-8981be9b2fe5553af35a43865d9ab4271c3aa2e2.tar.gz blackbird-op-linux-8981be9b2fe5553af35a43865d9ab4271c3aa2e2.zip |
Bluetooth: Fix write_room() calculation
The skb truesize of a 12-byte payload with a 10-byte head/tail
reserve is 768 bytes. Consequently, even with 40 tx_credits, at
most 6 packets could be queued at any one time:
40 tx_credits * 127-byte mtu < 768-byte truesize * 7
This error could also cause the tx queue to apparently stall if
credit flow control is disabled (where tx_credits is fixed at 5),
or if the receiver only granted a limited number of tx credits
(eg., less than 7).
Instead, track the outstanding number of queued packets not yet sent
in wmem_alloc and allow for a maximum of 40 queued packets. Report
the space avail for a single write() as the mtu * number of packets
left before reaching the maximum.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Tested-By: Alexander Holler <holler@ahsoftware.de>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Diffstat (limited to 'drivers/bluetooth')
0 files changed, 0 insertions, 0 deletions