diff options
| author | FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> | 2010-07-08 10:16:17 +0200 |
|---|---|---|
| committer | Jens Axboe <jaxboe@fusionio.com> | 2010-08-07 18:24:28 +0200 |
| commit | 610a63498f7f366031a6327eaaa9963ffa110b2b (patch) | |
| tree | 8ea7f0c9e1e2f41ee09677909a3491adeee31799 /crypto/proc.c | |
| parent | 9e094383b60066996fbc3b53891324e5d2ec858d (diff) | |
| download | blackbird-op-linux-610a63498f7f366031a6327eaaa9963ffa110b2b.tar.gz blackbird-op-linux-610a63498f7f366031a6327eaaa9963ffa110b2b.zip | |
scsi: fix discard page leak
We leak a page allocated for discard on some error conditions
(e.g. scsi_prep_state_check returns BLKPREP_DEFER in
scsi_setup_blk_pc_cmnd).
We unprep on requests that weren't prepped in the error path of
scsi_init_io. It makes the error path to clean up scsi commands messy.
Let's strictly apply the rule that we can't unprep on a request that
wasn't prepped.
Calling just scsi_put_command() in the error path of scsi_init_io() is
enough. We don't set REQ_DONTPREP yet.
scsi_setup_discard_cmnd can safely free a page on the error case with
the above rule.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Diffstat (limited to 'crypto/proc.c')
0 files changed, 0 insertions, 0 deletions
