summaryrefslogtreecommitdiffstats
path: root/crypto/crypto_null.c
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2011-12-23 13:39:34 -0300
committerMauro Carvalho Chehab <mchehab@redhat.com>2012-01-06 11:14:30 -0200
commiteabd0eaf4f390df102cd24a87300b0e5150cf189 (patch)
treed75ba29e5b48a71f816633d9751286819cba9882 /crypto/crypto_null.c
parent75e5ac7ea57ea56628f73a8a0aaf58f758aae43a (diff)
downloadblackbird-op-linux-eabd0eaf4f390df102cd24a87300b0e5150cf189.tar.gz
blackbird-op-linux-eabd0eaf4f390df102cd24a87300b0e5150cf189.zip
[media] drivers/staging/media/as102/as102_usb_drv.c: shift position of allocation code
The conditional after the kzalloc says that the tested expression should never be true, but if it were, the allocated data would have to be freed. This change just moves the allocation below the test, to avoid any possibility of the problem. A simplified version of the semantic match that finds the problem is as follows: (http://coccinelle.lip6.fr) // <smpl> @r exists@ local idexpression x; statement S; identifier f1; position p1,p2; expression *ptr != NULL; @@ x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S <... when != x when != if (...) { <+...x...+> } x->f1 ...> ( return \(0\|<+...x...+>\|ptr\); | return@p2 ...; ) @script:python@ p1 << r.p1; p2 << r.p2; @@ print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'crypto/crypto_null.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud