diff options
| author | Rusty Russell <rusty@rustcorp.com.au> | 2012-12-11 09:38:33 +1030 |
|---|---|---|
| committer | Rusty Russell <rusty@rustcorp.com.au> | 2012-12-14 13:06:43 +1030 |
| commit | 82fab442f5322b016f72891c0db2436c6a6c20b7 (patch) | |
| tree | 1b55bbf22569cf721c4bc13dc8f96652bad50a26 /arch/sparc | |
| parent | 54523ec71f8ce99accae97c74152f14f261f7e18 (diff) | |
| download | blackbird-op-linux-82fab442f5322b016f72891c0db2436c6a6c20b7.tar.gz blackbird-op-linux-82fab442f5322b016f72891c0db2436c6a6c20b7.zip | |
modules: don't hand 0 to vmalloc.
In commit d0a21265dfb5fa8a David Rientjes unified various archs'
module_alloc implementation (including x86) and removed the graduitous
shortcut for size == 0.
Then, in commit de7d2b567d040e3b, Joe Perches added a warning for
zero-length vmallocs, which can happen without kallsyms on modules
with no init sections (eg. zlib_deflate).
Fix this once and for all; the module code has to handle zero length
anyway, so get it right at the caller and remove the now-gratuitous
checks within the arch-specific module_alloc implementations.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=42608
Reported-by: Conrad Kostecki <ConiKost@gmx.de>
Cc: David Rientjes <rientjes@google.com>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'arch/sparc')
| -rw-r--r-- | arch/sparc/kernel/module.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/arch/sparc/kernel/module.c b/arch/sparc/kernel/module.c index f1ddc0d23679..4435488ebe25 100644 --- a/arch/sparc/kernel/module.c +++ b/arch/sparc/kernel/module.c @@ -43,10 +43,6 @@ void *module_alloc(unsigned long size) { void *ret; - /* We handle the zero case fine, unlike vmalloc */ - if (size == 0) - return NULL; - ret = module_map(size); if (ret) memset(ret, 0, size); |
