diff options
| author | Nathan Fontenot <nfont@austin.ibm.com> | 2008-08-26 05:33:34 +1000 |
|---|---|---|
| committer | Paul Mackerras <paulus@samba.org> | 2008-09-15 11:07:52 -0700 |
| commit | 525c411d400603665f8416f7e84bb14a43830027 (patch) | |
| tree | bda961397337b725615eba8e1d8514c54ff581db /arch/powerpc/platforms/pseries/reconfig.c | |
| parent | 57dda6ef5bd5b9e60410477ad29e654097e2cca1 (diff) | |
| download | blackbird-op-linux-525c411d400603665f8416f7e84bb14a43830027.tar.gz blackbird-op-linux-525c411d400603665f8416f7e84bb14a43830027.zip | |
powerpc: Check rc of notifier chain for memory remove
The return code from invocation of the notifier for
pSeries_reconfig_chain during update of the device tree is not
checked. This causes writes to /proc/ppc64/ofdt to update memory
properties (i.e. ibm,dyamic-reconfiguration-memory) to always
return success, instead of the result of the notifier chain.
This happens specifically when we remove/add memory from the
device tree on machines using memory specified in the
ibm,dynamic-reconfiguration-memory property of the device tree.
Signed-off-by: Nathan Fontenot <nfont@austin.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Diffstat (limited to 'arch/powerpc/platforms/pseries/reconfig.c')
| -rw-r--r-- | arch/powerpc/platforms/pseries/reconfig.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/arch/powerpc/platforms/pseries/reconfig.c b/arch/powerpc/platforms/pseries/reconfig.c index 7637bd38c795..c591a25b0b0d 100644 --- a/arch/powerpc/platforms/pseries/reconfig.c +++ b/arch/powerpc/platforms/pseries/reconfig.c @@ -466,11 +466,11 @@ static int do_update_property(char *buf, size_t bufsize) else action = PSERIES_DRCONF_MEM_REMOVE; - blocking_notifier_call_chain(&pSeries_reconfig_chain, - action, value); + rc = blocking_notifier_call_chain(&pSeries_reconfig_chain, + action, value); } - return 0; + return rc; } /** |
