diff options
| author | Hollis Blanchard <hollisb@us.ibm.com> | 2008-11-10 14:57:36 -0600 |
|---|---|---|
| committer | Avi Kivity <avi@redhat.com> | 2008-12-31 16:52:26 +0200 |
| commit | fe4e771d5c37f0949047faf95d16a512b21406bf (patch) | |
| tree | 518b4ff17a8e1e62b747ce1912c08b62883d2855 /arch/powerpc/kvm/44x_emulate.c | |
| parent | df9b856c454e331bc394c80903fcdea19cae2a33 (diff) | |
| download | blackbird-op-linux-fe4e771d5c37f0949047faf95d16a512b21406bf.tar.gz blackbird-op-linux-fe4e771d5c37f0949047faf95d16a512b21406bf.zip | |
KVM: ppc: fix userspace mapping invalidation on context switch
We used to defer invalidating userspace TLB entries until jumping out of the
kernel. This was causing MMU weirdness most easily triggered by using a pipe in
the guest, e.g. "dmesg | tail". I believe the problem was that after the guest
kernel changed the PID (part of context switch), the old process's mappings
were still present, and so copy_to_user() on the "return to new process" path
ended up using stale mappings.
Testing with large pages (64K) exposed the problem, probably because with 4K
pages, pressure on the TLB faulted all process A's mappings out before the
guest kernel could insert any for process B.
Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
Diffstat (limited to 'arch/powerpc/kvm/44x_emulate.c')
| -rw-r--r-- | arch/powerpc/kvm/44x_emulate.c | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/arch/powerpc/kvm/44x_emulate.c b/arch/powerpc/kvm/44x_emulate.c index 9bc50cebf9ec..9ef79c78ede9 100644 --- a/arch/powerpc/kvm/44x_emulate.c +++ b/arch/powerpc/kvm/44x_emulate.c @@ -21,6 +21,7 @@ #include <asm/dcr.h> #include <asm/dcr-regs.h> #include <asm/disassemble.h> +#include <asm/kvm_44x.h> #include "booke.h" #include "44x_tlb.h" @@ -38,14 +39,6 @@ #define XOP_ICCCI 966 #define XOP_TLBWE 978 -static inline void kvmppc_set_pid(struct kvm_vcpu *vcpu, u32 new_pid) -{ - if (vcpu->arch.pid != new_pid) { - vcpu->arch.pid = new_pid; - vcpu->arch.swap_pid = 1; - } -} - static void kvmppc_emul_rfi(struct kvm_vcpu *vcpu) { vcpu->arch.pc = vcpu->arch.srr0; |
