diff options
author | Atsushi Nemoto <anemo@mba.ocn.ne.jp> | 2007-11-12 02:05:18 +0900 |
---|---|---|
committer | Ralf Baechle <ralf@linux-mips.org> | 2008-09-21 14:52:57 +0200 |
commit | c65a5480ff29198c241f11d39d9e34ab22c72c69 (patch) | |
tree | bb6fadfbb27c607b4c99745844339f9f1e740940 /arch/mips/kernel/cpu-probe.c | |
parent | 6657fe0a0281e06ff46eb42bc18ecb68d8b14b27 (diff) | |
download | blackbird-op-linux-c65a5480ff29198c241f11d39d9e34ab22c72c69.tar.gz blackbird-op-linux-c65a5480ff29198c241f11d39d9e34ab22c72c69.zip |
[MIPS] Fix potential latency problem due to non-atomic cpu_wait.
If an interrupt happened between checking of NEED_RESCHED and WAIT
instruction, adjust EPC to restart from checking of NEED_RESCHED.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'arch/mips/kernel/cpu-probe.c')
-rw-r--r-- | arch/mips/kernel/cpu-probe.c | 16 |
1 files changed, 2 insertions, 14 deletions
diff --git a/arch/mips/kernel/cpu-probe.c b/arch/mips/kernel/cpu-probe.c index 335a6ae3d594..11c92dc53791 100644 --- a/arch/mips/kernel/cpu-probe.c +++ b/arch/mips/kernel/cpu-probe.c @@ -45,18 +45,7 @@ static void r39xx_wait(void) local_irq_enable(); } -/* - * There is a race when WAIT instruction executed with interrupt - * enabled. - * But it is implementation-dependent wheter the pipelie restarts when - * a non-enabled interrupt is requested. - */ -static void r4k_wait(void) -{ - __asm__(" .set mips3 \n" - " wait \n" - " .set mips0 \n"); -} +extern void r4k_wait(void); /* * This variant is preferable as it allows testing need_resched and going to @@ -128,7 +117,7 @@ static int __init wait_disable(char *s) __setup("nowait", wait_disable); -static inline void check_wait(void) +void __init check_wait(void) { struct cpuinfo_mips *c = ¤t_cpu_data; @@ -242,7 +231,6 @@ static inline void check_errata(void) void __init check_bugs32(void) { - check_wait(); check_errata(); } |