diff options
| author | Julia Lawall <julia@diku.dk> | 2009-10-17 08:42:49 +0200 |
|---|---|---|
| committer | Ben Dooks <ben-linux@fluff.org> | 2009-10-28 18:25:57 +0000 |
| commit | 60e5c1b5ecd99e06d3133a2a20d58d3c2b9968ac (patch) | |
| tree | 84a2faad185d03646999895ed4d074c7ada03fd7 /arch/arm/plat-s3c24xx | |
| parent | d3bf3956c75b38def079fb6db40b5cf3f1466a93 (diff) | |
| download | blackbird-op-linux-60e5c1b5ecd99e06d3133a2a20d58d3c2b9968ac.tar.gz blackbird-op-linux-60e5c1b5ecd99e06d3133a2a20d58d3c2b9968ac.zip | |
ARM: S3C24XX: arch/arm/plat-s3c24xx: Move dereference after NULL test
If the NULL test on buf is needed, then the dereference should be after the
NULL test.
A simplified version of the semantic match that detects this problem is as
follows (http://coccinelle.lip6.fr/):
// <smpl>
@match exists@
expression x, E;
identifier fld;
@@
* x->fld
... when != \(x = E\|&x\)
* x == NULL
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Diffstat (limited to 'arch/arm/plat-s3c24xx')
| -rw-r--r-- | arch/arm/plat-s3c24xx/dma.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c index 196b19123653..f046f8c51084 100644 --- a/arch/arm/plat-s3c24xx/dma.c +++ b/arch/arm/plat-s3c24xx/dma.c @@ -208,14 +208,14 @@ s3c2410_dma_loadbuffer(struct s3c2410_dma_chan *chan, { unsigned long reload; - pr_debug("s3c2410_chan_loadbuffer: loading buff %p (0x%08lx,0x%06x)\n", - buf, (unsigned long)buf->data, buf->size); - if (buf == NULL) { dmawarn("buffer is NULL\n"); return -EINVAL; } + pr_debug("s3c2410_chan_loadbuffer: loading buff %p (0x%08lx,0x%06x)\n", + buf, (unsigned long)buf->data, buf->size); + /* check the state of the channel before we do anything */ if (chan->load_state == S3C2410_DMALOAD_1LOADED) { |
