summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBingbu Cao <bingbu.cao@intel.com>2019-12-30 04:09:04 +0100
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>2020-01-04 08:11:51 +0100
commit92590966fe5b6cc1930b1ad36d4f84e9bc88b982 (patch)
treea72a64027fa5d29552d91ba63830feca2cc299c1
parent1451d5ae351d938a0ab1677498c893f17b9ee21d (diff)
downloadblackbird-op-linux-92590966fe5b6cc1930b1ad36d4f84e9bc88b982.tar.gz
blackbird-op-linux-92590966fe5b6cc1930b1ad36d4f84e9bc88b982.zip
media: staging/intel-ipu3: set the main output as mandatory
From firmware perspective, the main output for each pipe is mandatory and must be enabled. This patch set the link between imgu subdev and main output as IMMUTABLE by default. Signed-off-by: Bingbu Cao <bingbu.cao@intel.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
-rw-r--r--drivers/staging/media/ipu3/TODO3
-rw-r--r--drivers/staging/media/ipu3/ipu3-v4l2.c5
2 files changed, 5 insertions, 3 deletions
diff --git a/drivers/staging/media/ipu3/TODO b/drivers/staging/media/ipu3/TODO
index b44bb4a72ca7..9ef036f23a21 100644
--- a/drivers/staging/media/ipu3/TODO
+++ b/drivers/staging/media/ipu3/TODO
@@ -5,9 +5,6 @@ staging directory.
as well as formats and the binary used to a request. Remove the
opportunistic buffer management. (Sakari)
-- Using ENABLED and IMMUTABLE link flags for the links where those are
- relevant. (Sakari)
-
- IPU3 driver documentation (Laurent)
Comments on configuring v4l2 subdevs for CIO2 and ImgU.
diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c
index 3c7ad1eed434..569e27b824c8 100644
--- a/drivers/staging/media/ipu3/ipu3-v4l2.c
+++ b/drivers/staging/media/ipu3/ipu3-v4l2.c
@@ -1260,6 +1260,11 @@ static int imgu_v4l2_node_setup(struct imgu_device *imgu, unsigned int pipe,
r = media_create_pad_link(&vdev->entity, 0, &sd->entity,
node_num, flags);
} else {
+ if (node->id == IMGU_NODE_OUT) {
+ flags |= MEDIA_LNK_FL_ENABLED | MEDIA_LNK_FL_IMMUTABLE;
+ node->enabled = true;
+ }
+
r = media_create_pad_link(&sd->entity, node_num, &vdev->entity,
0, flags);
}
OpenPOWER on IntegriCloud