summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMartin Petermann <martin@linux.vnet.ibm.com>2008-11-26 18:07:35 +0100
committerJames Bottomley <James.Bottomley@HansenPartnership.com>2008-12-01 10:16:44 -0600
commitbce02614cd1b3d669af1195695e503e818b60fae (patch)
tree4627c43bda7cf117c85832c795a436ebf24c5658
parent21098c68df7115554fe041170899bdff709efd08 (diff)
downloadblackbird-op-linux-bce02614cd1b3d669af1195695e503e818b60fae.tar.gz
blackbird-op-linux-bce02614cd1b3d669af1195695e503e818b60fae.zip
[SCSI] zfcp: fix remote port status check
For an incoming RSCN it was checked by the ZFCP_STATUS_PORT_DID_DID define to re-open a remote port or to test the connection. Since this define was re-used it was also necessary to replace that define with ZFCP_STATUS_PORT_PHYS_OPEN. Signed-off-by: Martin Petermann <martin@linux.vnet.ibm.com> Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
-rw-r--r--drivers/s390/scsi/zfcp_fc.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/s390/scsi/zfcp_fc.c b/drivers/s390/scsi/zfcp_fc.c
index 1a7c80a77ff5..c5f4bd217bfe 100644
--- a/drivers/s390/scsi/zfcp_fc.c
+++ b/drivers/s390/scsi/zfcp_fc.c
@@ -125,8 +125,7 @@ static void _zfcp_fc_incoming_rscn(struct zfcp_fsf_req *fsf_req, u32 range,
read_lock_irqsave(&zfcp_data.config_lock, flags);
list_for_each_entry(port, &fsf_req->adapter->port_list_head, list) {
- /* FIXME: ZFCP_STATUS_PORT_DID_DID check is racy */
- if (!(atomic_read(&port->status) & ZFCP_STATUS_PORT_DID_DID))
+ if (!(atomic_read(&port->status) & ZFCP_STATUS_PORT_PHYS_OPEN))
/* Try to connect to unused ports anyway. */
zfcp_erp_port_reopen(port,
ZFCP_STATUS_COMMON_ERP_FAILED,
OpenPOWER on IntegriCloud