summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid S. Miller <davem@sunset.davemloft.net>2007-07-16 17:05:11 -0700
committerDavid S. Miller <davem@sunset.davemloft.net>2007-07-16 17:12:00 -0700
commitf798634d806615bee27d1b83479034087a02aa0f (patch)
tree74af3b0a5469886f69dbd13b0a70cc0ca4318227
parent778feeb4757daef5d7118feab2319142367910dd (diff)
downloadblackbird-op-linux-f798634d806615bee27d1b83479034087a02aa0f.tar.gz
blackbird-op-linux-f798634d806615bee27d1b83479034087a02aa0f.zip
[SERIAL] SUNHV: Fix jerky console on LDOM guests.
Mixing putchar() and write() hvcalls does not work %100 correctly. But we should be using write() all the time if we can, even from ->start_tx(), anyways. Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/serial/sunhv.c12
1 files changed, 1 insertions, 11 deletions
diff --git a/drivers/serial/sunhv.c b/drivers/serial/sunhv.c
index 17bcca53d6a1..d82be42ff29a 100644
--- a/drivers/serial/sunhv.c
+++ b/drivers/serial/sunhv.c
@@ -258,17 +258,7 @@ static void sunhv_stop_tx(struct uart_port *port)
/* port->lock held by caller. */
static void sunhv_start_tx(struct uart_port *port)
{
- struct circ_buf *xmit = &port->info->xmit;
-
- while (!uart_circ_empty(xmit)) {
- long status = sun4v_con_putchar(xmit->buf[xmit->tail]);
-
- if (status != HV_EOK)
- break;
-
- xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1);
- port->icount.tx++;
- }
+ transmit_chars(port);
}
/* port->lock is not held. */
OpenPOWER on IntegriCloud