summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohn Ogness <john.ogness@linutronix.de>2015-08-14 18:01:02 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-08-14 17:19:50 -0700
commiteafb9eea7622d765effb1a06f8cf5eb31fa018f6 (patch)
treea6e34ac7fb089675e7e60beef391cb6825284d3d
parent830acf9e3044d4644f91b4418ef35a2094089946 (diff)
downloadblackbird-op-linux-eafb9eea7622d765effb1a06f8cf5eb31fa018f6.tar.gz
blackbird-op-linux-eafb9eea7622d765effb1a06f8cf5eb31fa018f6.zip
serial: 8250: move rx_running out of the bitfield
That bitfield is modified by read + or + write operation. If someone sets any of the other two bits it might render the lock useless. While at it, remove other bitfields as well to avoid more such errors. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: John Ogness <john.ogness@linutronix.de> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/tty/serial/8250/8250.h6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/tty/serial/8250/8250.h b/drivers/tty/serial/8250/8250.h
index dd233108ec07..d54dcd87c67e 100644
--- a/drivers/tty/serial/8250/8250.h
+++ b/drivers/tty/serial/8250/8250.h
@@ -42,9 +42,9 @@ struct uart_8250_dma {
size_t rx_size;
size_t tx_size;
- unsigned char tx_running:1;
- unsigned char tx_err: 1;
- unsigned char rx_running:1;
+ unsigned char tx_running;
+ unsigned char tx_err;
+ unsigned char rx_running;
};
struct old_serial_port {
OpenPOWER on IntegriCloud