diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2011-02-21 14:19:42 +0100 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2011-02-21 21:20:00 +0100 |
| commit | 8fff39e06987492da3d4a0b9ec7cdbd245b6762b (patch) | |
| tree | 751d1930d88def0238e927ac4e03f23703656a4d | |
| parent | ed4dea6e0e33a3e58d8b77b775a8f0e433e7a005 (diff) | |
| download | blackbird-op-linux-8fff39e06987492da3d4a0b9ec7cdbd245b6762b.tar.gz blackbird-op-linux-8fff39e06987492da3d4a0b9ec7cdbd245b6762b.zip | |
genirq: Add missing break in __irq_set_trigger()
The switch case in __irq_set_trigger() lacks a break, which emits a
pr_err unconditionally on success.
Reported-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
| -rw-r--r-- | kernel/irq/manage.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index 6cca1956c503..01f8a9519e63 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -567,6 +567,7 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned int irq, if (chip != desc->irq_data.chip) irq_chip_set_defaults(desc->irq_data.chip); ret = 0; + break; default: pr_err("setting trigger mode %lu for irq %u failed (%pF)\n", flags, irq, chip->irq_set_type); |
