diff options
| author | Dan Carpenter <error27@gmail.com> | 2009-04-11 01:52:29 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-04-11 01:52:29 -0700 |
| commit | 57401d5e36d2966247e9c06b94f5133609c8da21 (patch) | |
| tree | be9f5df2f4fe924303d897a16e7af3b9cd75c422 | |
| parent | 3384901f1b1af676ccb9d75aa23a568c294c527b (diff) | |
| download | blackbird-op-linux-57401d5e36d2966247e9c06b94f5133609c8da21.tar.gz blackbird-op-linux-57401d5e36d2966247e9c06b94f5133609c8da21.zip | |
phy: error handling for platform_device_register_simple()
platform_device_register_simple() returns ERR_PTR() and not NULL.
Found by smatch (http://repo.or.cz/w/smatch.git). Compile tested.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/phy/fixed.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/phy/fixed.c b/drivers/net/phy/fixed.c index cf24cc34debe..e7070515d2e3 100644 --- a/drivers/net/phy/fixed.c +++ b/drivers/net/phy/fixed.c @@ -19,6 +19,7 @@ #include <linux/mii.h> #include <linux/phy.h> #include <linux/phy_fixed.h> +#include <linux/err.h> #define MII_REGS_NUM 29 @@ -207,8 +208,8 @@ static int __init fixed_mdio_bus_init(void) int ret; pdev = platform_device_register_simple("Fixed MDIO bus", 0, NULL, 0); - if (!pdev) { - ret = -ENOMEM; + if (IS_ERR(pdev)) { + ret = PTR_ERR(pdev); goto err_pdev; } |
